Skip to content

Stream support optional input efif - #9884

Open
efifogel wants to merge 2 commits into
CGAL:mainfrom
efifogel:Stream_support-optional_input-efif
Open

efifogel wants to merge 2 commits into
CGAL:mainfrom
efifogel:Stream_support-optional_input-efif

Conversation

@efifogel

Copy link
Copy Markdown
Member

Summary of Changes

Read an empty std::optional back

Output_rep<std::optional<T>> writes an empty optional as "--", but Input_rep<std::optional<T>> always reads a T, so that output can't be read back (e.g., a CKvA point written by the 2D arrangement demo).

I added a test and kept changes to a minimum.

Release Management

  • Affected package(s): Stream_support
  • Issue(s) solved (if any): fix #0000, fix #0000,...
  • Feature/Small Feature (if any):
  • Link to compiled documentation (obligatory for small feature) wrong link name to be changed
  • License and copyright ownership: unchanged

Output_rep<std::optional<T>> writes an empty optional as "--", but
Input_rep<std::optional<T>> always read a T, so such output could not be read
back (e.g., a CKvA point written by the 2D arrangement demo). Added a test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant